Done
Pinned fields
Click on the next to a field label to start pinning.
Details
Details
Assignee
Josh Meyers
Josh MeyersReporter
Josh Meyers
Josh MeyersPlanned End
Apr 07, 2017, 5:00 PM
Location (migrated)
Components
Checklist
Checklist
Created April 4, 2017 at 5:21 PM
Updated April 14, 2017 at 11:35 AM
Resolved April 14, 2017 at 11:35 AM
For physical optics PSFs, we require a model of the pupil obscuration, which I propose should be a part of
afw.cameraGeom.Camera
. In particular, I plan to add abstract base classescameraGeom.PupilFactory
cameraGeom.Pupil
and make the following API changes:
Camera
gains a._pupilFactory
attribute andCamera.__init__
gains apupilFactory
kwarg.camera factories
makeCameraFromPath
andmakeCameraFromCatalogs
gain apupilFactory
kwarg with default value equal tocameraGeom.PupilFactory
CameraMapper
gains an attributepupilFactoryClass
with valuecameraGeom.pupilFactory
. Subclasses (e.g.,HscMapper
) can then set this attribute to a camera-specific pupilFactory as desired.CameraMapper._makeCamera
passesself.pupilFactoryClass
tomakeCameraFromPath
See CLO post here for more details. Also, since some discussion already exists on the CLO post, please add additional comments there.