singleFrameDriver is only running with a single process

Description

singleFrameDriver.py is only using a single process. The problem appears to be the change to use a ButlerInitializedTaskRunner, which doesn't inherit from BatchTaskRunner.

Checklist

Lucidchart Diagrams

Issue Matrix

hide

Activity

Show:
Tim Jenness
August 5, 2016 at 8:12 AM
(edited)
Jim Bosch
August 5, 2016 at 7:36 AM

To be honest, while I do remember being unhappy with super in the past, I don't remember the arguments for and against anymore, and I don't think that unease extended to diamond inheritance when all classes have a nontrivial constructors; I think super is till the only way to handle that situation correctly.

I wonder what the situation is in Python 3 (or futurized Python 2), where I hear super is better - ?

Paul Price
August 4, 2016 at 7:50 PM

Thanks, I'll go ahead and merge now.

I'm not sure how this is any more fragile than usual, nor how super would fix it (using super in a class hierarchy that doesn't all use super is dangerous, and I thought you were against using it for that reason); perhaps you could explain that offline for me?

Paul Price
August 4, 2016 at 7:50 PM

Merged to master.

Jim Bosch
August 4, 2016 at 5:29 PM

I don't disagree with your analysis that the current code is safe, but I still worry that it's fragile w.r.t. the addition of new subclasses. That said, TaskRunner is perhaps not long for this world with SuperTask on the horizon, so it's probably not necessary to fix this now.

Done
Pinned fields
Click on the next to a field label to start pinning.

Details

Assignee

Reporter

Reviewers

Jim Bosch

Story Points

RubinTeam

Components

Sprint

None

Checklist

Created August 4, 2016 at 12:47 PM
Updated November 16, 2016 at 6:57 AM
Resolved August 4, 2016 at 7:50 PM