Done
Pinned fields
Click on the next to a field label to start pinning.
Details
Details
Assignee
Jeremy McCormick
Jeremy McCormickReporter
Jeremy McCormick
Jeremy McCormickReviewers
Gregory Dubois-Felsmann
Story Points
1
RubinTeam
Data Engineering
Components
Checklist
Checklist
Created April 17, 2024 at 10:03 PM
Updated July 29, 2024 at 11:56 PM
Resolved July 29, 2024 at 11:56 PM
The https://rubinobs.atlassian.net/browse/DM-43371 update will make the
length
field a requirement for columns with datatypes that are considered sized, namelychar
,string
,unicode
, andbinary
. This change would cause validation errors in sdm_schemas, as there are currently some columns with these types that are missing an explicitlength
field. For many of these, e.g., columns in the ObsCore schemas, anarraysize
is present, which should instead be assigned tolength
.A related issue is that there are a number of columns in the ObsCore-related schemas that have been assigned an incorrect type of
char
but should instead be usingstring
. This was confirmed by looking at DDL dumped from the live version of an ObsCore database, where all such columns areVARCHAR
, defined in Felis asstring
.Tables affected by the above problems with lengths and datatypes include:
dp02_obscore
obsloctap
oga_live_obscore
imsim (There is just a minor fix needed here to add the length field to a single column.)
In the ObsCore-related schemas, there is an additional special case where
access_url
should be using the Felistext
type rather thanchar
, as the live ObsCore database usesTEXT
in MySQL.