Skip to:

  1. Skip to Jira Navigation
  2. Skip to Side Navigation
  3. Skip to Main Content

Use --fail-fast in ap_verify to halt execution on first error

Description

I found the --fail-fast option to pipetask, which causes the pipeline execution to fail immediately on error, instead of trying to continue execution. I think this is what we want for ap_verify, as it's purpose is to test our pipeline, and any failures should halt.

Adding `"--fail-fast",` to line 98 of ap_verify's pipeline_driver.py seems to have done the trick.

Alternately, we could make this a commandline option to ap_verify, if we don't want to always fail immediately (but I think we do?).

Checklist

Lucidchart Diagrams

Issue Matrix

hide

Activity

Show:

Krzysztof Findeisen 
August 29, 2022 at 10:13 PM

Following a discussion on #dm-alert-prod about whether ap_verify still has the same purpose it was originally written for (it does not, and I'm the only one who thought otherwise), I've no further objections to the PR as-is.

John Parejko 
May 9, 2022 at 10:11 PM

Adding it as a commandline option is less trivial than this commit, so it might be a while before I get to it.

Krzysztof Findeisen 
May 4, 2022 at 9:09 PM

If Meredith thinks that's best, then I have no objections.

Meredith Rawls 
May 4, 2022 at 7:16 PM

I feel like you two disagree on the purpose of ap_verify. Both your views make sense to me... it sounds like John wants "fail fast" to be the ap_verify default to make debugging with it go faster, and Krzysztof is concerned this goes counter to the main purpose of ap_verify as a tool to reproduce runs.

Could we compromise by making "fail fast" an acceptable command-line option for ap_verify (so John can use it for debugging when necessary), but NOT having it be the default (since it's not necessarily desired behavior for checking runs can be reproduced)?

Krzysztof Findeisen 
May 4, 2022 at 4:55 PM

I'm sorry, but I still don't understand what you are trying to do (with either change), so I don't believe I'm in a position to approve or disapprove. Perhaps has a better understanding of what this would mean for our workflows (if she's not too busy)?

Done
Pinned fields
Click on the next to a field label to start pinning.

Details

Assignee

Reporter

Labels

Reviewers

Krzysztof Findeisen

Story Points

RubinTeam

Components

Sprint

Parent

Checklist

Created April 27, 2022 at 11:51 PM
Updated August 29, 2022 at 10:33 PM
Resolved August 29, 2022 at 10:33 PM