Skip to:

  1. Skip to Jira Navigation
  2. Skip to Side Navigation
  3. Skip to Main Content

Use TraceRadius in GAaP plugin

Description

https://rubinobs.atlassian.net/browse/DM-31345#icft=DM-31345 modified the call to `getTraceRadius` to `getDeterminantRadius` to keep the size definition consistent. However, the determinant radius measured by baseSdssShape may not always be defined, especially when PSF model contains negative pixels, leading to failures. These were the causes for the rare failures in MERIAN processing by and a single DP0.2 error reported in this Confluence page. While the resolution to accept it as it is, the fix is fairly straightforward (replace all calls of `getDeterminantRadius` to `getTraceRadius`). This change will still result in failures when the PSF moments themselves are undefined. This ticket also makes the error message more useful so that the cause of this failure becomes apparent.

Checklist

Lucidchart Diagrams

Issue Matrix

hide

Activity

Show:
Yusra AlSayyad
March 20, 2022 at 1:28 AM

preops because of the investigation of the DP0.2 step1 errors reported

Arun Kannawadi
February 8, 2022 at 8:31 PM

Thanks for the comments, Lee. Jenkins run is successful after incorporating your comments: https://ci.lsst.codes/blue/organizations/jenkins/stack-os-matrix/detail/stack-os-matrix/35848/pipeline

 

Merging now.

Lee Kelvin
February 7, 2022 at 7:38 PM

Thanks Arun. Can confirm that using this ticket branch removes all of the errors originally reported in https://rubinobs.atlassian.net/browse/DM-33375#icft=DM-33375. Specifically, I'm running this command:

This is running on the tiger2-sumire machine at Princeton.

I've left a few minor comments on the GH PR which I hope are helpful. These aren't major, so I'll leave it up to you to decide if you'd like to run another Jenkins before merging or not. Otherwise, very nicely done, thanks!

Arun Kannawadi
February 1, 2022 at 6:56 PM

The backporting request was raised in the hope that this ticket will avoid the error seen in DP0.2 processing. It now appears that the proposed fix will not avoid the error. Furthermore, the change in definition would mean that step1 has to be rerun for consistency and the motivation to do so is not valid given that this ticket will not avoid the error. Hence, withdrawing the backport request.

Arun Kannawadi
February 1, 2022 at 6:54 PM

The error message in DP0.2 occurs before GAaP plugin in run in `characterizeImage` task. The root cause of the error is that the simple PSF in `characterizeImage` having `nan` moments. Both trace radius and determinant radius will be nan in this case. 

Done
Pinned fields
Click on the next to a field label to start pinning.

Details

Assignee

Reporter

Reviewers

Lee Kelvin

Story Points

RubinTeam

Components

Checklist

Created January 28, 2022 at 7:11 PM
Updated March 20, 2022 at 1:28 AM
Resolved February 8, 2022 at 8:32 PM