Skip to:

  1. Skip to Jira Navigation
  2. Skip to Side Navigation
  3. Skip to Main Content

Make obs_cfht dependency in jointcal optional

Description

Jointcal depends on obs_cfht to enable some tests.  Precedent in the rest of the stack is to make all dependencies from algorithm packages on obs packages optional, with skip guards on the tests.

Checklist

Lucidchart Diagrams

Issue Matrix

hide

Activity

Show:
John Parejko
April 23, 2019 at 8:20 PM

Thanks for the review: this version is definitely cleaner.

Jenkins passed: https://ci.lsst.codes/blue/organizations/jenkins/stack-os-matrix/detail/stack-os-matrix/29709/pipeline

Merged and done.

Paul Price
April 23, 2019 at 1:58 PM

That's great, thanks!

John Parejko
April 22, 2019 at 9:53 PM

That's reasonable. What do you think about the latest version?

Paul Price
April 22, 2019 at 9:16 PM

I think having the function that has the dependency do the skip reflects the actual reason you're skipping, and is therefore safer and lower maintenance.

John Parejko
April 22, 2019 at 9:13 PM

I'm torn on that: this way, the whole test class is marked as "skip", while your suggestion would result in the classes' setUp being run until that exception is triggered. I don't know if that is an issue worth considering?

Done
Pinned fields
Click on the next to a field label to start pinning.

Details

Assignee

Reporter

Labels

Reviewers

Paul Price

Story Points

RubinTeam

Sprint

None

Parent

Checklist

Created April 22, 2019 at 5:19 PM
Updated May 21, 2019 at 10:52 PM
Resolved April 23, 2019 at 8:20 PM