Skip to:

  1. Skip to Jira Navigation
  2. Skip to Side Navigation
  3. Skip to Main Content

measureCrosstalk was broken by the move of crosstalk correction to above assembly

Description

When the crosstalk correction code was moved to above CCD assembly the routine extractAmp was changed to work on un-assembled CCDs.  This broke measureCrosstalk (this is hard to fix nicely until DM-15409 is resolved).

Additionally, measureCrosstalk assumes that you have enough data to constrain all the crosstalk coefficients, and has no way to write the outputs.  Please fix these while you have the package open.

Checklist

Lucidchart Diagrams

Issue Matrix

hide

Activity

Show:
Robert Lupton
August 14, 2018 at 6:00 PM

Responded to comments, merged, pushed

Paul Price
August 14, 2018 at 8:23 AM

Looks good. I've made a few minor comments on the GitHub PR.

Robert Lupton
August 13, 2018 at 10:06 AM

Sorry, that comment applied to an obs_lsstCam change. Yes, I did this on a branch and will put it up for review.

John Swinbank
August 13, 2018 at 10:02 AM

— I see this on a branch, but it hasn't made it to master. (And obviously it'd need to be reviewed, etc, before it did.)

Robert Lupton
August 12, 2018 at 5:19 PM

Fixed on master.

Done
Pinned fields
Click on the next to a field label to start pinning.

Details

Assignee

Reporter

Reviewers

Paul Price

RubinTeam

Components

Checklist

Created August 10, 2018 at 2:32 PM
Updated August 14, 2018 at 6:00 PM
Resolved August 14, 2018 at 6:00 PM