Skip to:

  1. Skip to Jira Navigation
  2. Skip to Side Navigation
  3. Skip to Main Content

Add ap_verify to lsst_distrib

Description

Add ap_verify to lsst_distrib, and add ap_pipe and its dependencies to lsst_apps. This includes:

  1. Moving the packages to the lsst organization, and assigning admin privileges as described in the developer guide. [Note: this step cannot have an associated pull request].

  2. Confirming that packages follow Stack conventions (e.g., directory structure).

  3. Registering any missing packages with repos.yaml.

  4. Double-checking that any data package that is an optional dependency of a non-data package is also in manifest.remap.

  5. Adding ap_verify and ap_pipe to their respective top-level packages' table files.

Checklist

Lucidchart Diagrams

Issue Matrix

hide

Activity

Show:
Krzysztof Findeisen
October 3, 2018 at 9:45 AM

Thanks for the feedback!

Tim Jenness
October 2, 2018 at 3:18 PM

Looks okay. I've got some minor comments on left over python2 compatibility and a table file with cruft in. I found naming the PRs after the Jira ticket name to be extremely confusing given that the PRs 4 out of 5 were not related to ap_verify being added to lsst_distrib.

Krzysztof Findeisen
September 28, 2018 at 3:34 PM
(edited)

Hi , as part of this ticket I had to do a fair bit of cleanup to get the ap_* packages to comply with Stack standards. Can you take a look and confirm that everything is now done correctly? Thanks!

Jenkins build: https://ci.lsst.codes/blue/organizations/jenkins/stack-os-matrix/detail/stack-os-matrix/28724/

Krzysztof Findeisen
September 21, 2018 at 3:37 PM

All steps done except #5, which requires resolution of https://rubinobs.atlassian.net/browse/DM-15775#icft=DM-15775 first.

Krzysztof Findeisen
August 30, 2018 at 3:11 PM

Per our August 30 meeting, we will try to include l1dbproto in lsst_apps (with the developers' permission) instead of making it an optional dependency of ap_association.

Done
Pinned fields
Click on the next to a field label to start pinning.

Details

Assignee

Reporter

Reviewers

Tim Jenness

Story Points

RubinTeam

Components

Sprint

None

Parent

Checklist

Created May 1, 2018 at 2:02 PM
Updated October 3, 2018 at 10:18 AM
Resolved October 3, 2018 at 9:45 AM